lkml.org 
[lkml]   [2020]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/2] ARM: dts: exynos: tiny4412: add fimd node
    On Tue, 7 Jan 2020 at 09:45, Krzysztof Kozlowski <krzk@kernel.org> wrote:
    >
    > On Mon, Jan 06, 2020 at 07:10:02PM +0000, Yangtao Li wrote:
    > > The patch adds fimd node for tiny4412 device.
    >
    > Hi,
    >
    > Thanks for the patch.
    >
    > Do not use "This patch ..." sentences but simple, imperative mode:
    > https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L151
    >
    > Here you do not add FIMD node, because the FIMD is already there
    > (defined in exynos4.dtsi). You however enable it.
    >
    > Enabling it without panel does not really make sense - does it work?
    > I guess not, so this should be squashed with second patch.

    ... unless it really works without panel, then it makes sense to keep
    it separate. However in such case, the #cells properties belong to
    second patch.

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2020-01-07 09:49    [W:7.523 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site