lkml.org 
[lkml]   [2020]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fs: fix ext4 unused-variable warning
On Tue, Jan 07, 2020 at 09:02:12PM +0100, Arnd Bergmann wrote:
> A bugfix introduce a harmless warning:
>
> fs/ext4/inode.c: In function 'ext4_page_mkwrite':
> fs/ext4/inode.c:5910:24: error: unused variable 'mapping' [-Werror=unused-variable]
>
> Remove the now-unused variable.
>
> Fixes: 4a58d8158f6d ("fs: Fix page_mkwrite off-by-one errors")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

FWIW I dropped the f2fs parts of the patch because there were conflicts
and they never acked the patch, so I fixed this at the same time.

--D

> ---
> fs/ext4/inode.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 9a3e8d075cd0..d0049fd0bfd4 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -5907,7 +5907,6 @@ vm_fault_t ext4_page_mkwrite(struct vm_fault *vmf)
> vm_fault_t ret;
> struct file *file = vma->vm_file;
> struct inode *inode = file_inode(file);
> - struct address_space *mapping = inode->i_mapping;
> handle_t *handle;
> get_block_t *get_block;
> int retries = 0;
> --
> 2.20.0
>

\
 
 \ /
  Last update: 2020-01-08 00:20    [W:0.056 / U:6.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site