lkml.org 
[lkml]   [2020]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] sched, fair: Allow a small load imbalance between low utilisation SD_NUMA domains v3
On Tue, 7 Jan 2020 at 02:51, Hillf Danton <hdanton@sina.com> wrote:
>
>
> Hi Folks
>
> On Mon, 06 Jan 2020 11:44:57 -0500 Rik van Riel wrote:
> > On Mon, 2020-01-06 at 16:33 +0000, Mel Gorman wrote:
> > > On Mon, Jan 06, 2020 at 10:47:18AM -0500, Rik van Riel wrote:
> > > > > + imbalance_adj = (100 / (env->sd->imbalance_pct - 100)) - 1;
> > > > > +
> > > > > + /*
> > > > > + * Allow small imbalances when the busiest group has
> > > > > + * low utilisation.
> > > > > + */
> > > > > + imbalance_max = imbalance_adj << 1;
> > > > > + if (busiest->sum_nr_running < imbalance_max)
> > > > > + env->imbalance -= min(env->imbalance, imbalance_adj);
> > > > > + }
> > > > > +
> > > >
> > > > Wait, so imbalance_max is a function only of
> > > > env->sd->imbalance_pct, and it gets compared
> > > > against busiest->sum_nr_running, which is related
> > > > to the number of CPUs in the node?
> > > >
> > >
> > > It's not directly related to the number of CPUs in the node. Are you
> > > thinking of busiest->group_weight?
> >
> > I am, because as it is right now that if condition
> > looks like it might never be true for imbalance_pct 115.
> >
> > Presumably you put that check there for a reason, and
> > would like it to trigger when the amount by which a node
> > is busy is less than 2 * (imbalance_pct - 100).
>
>
> If three per cent can make any sense in helping determine utilisation
> low then the busy load has to meet
>
> busiest->sum_nr_running < max(3, cpus in the node / 32);

I agree that we should take into account the size or the utilization
of the node in some way

>
> And we can't skip pulling tasks from a numa node without comparing it
> to the local load
>
> local->sum_nr_running * env->sd->imbalance_pct <
> busiest->sum_nr_running * 100;

A similar test has already been done in fbg and we call calculate
imbalance only if busiest is busier than local

>
> with imbalance_pct taken into account.
>
> Hillf
>

\
 
 \ /
  Last update: 2020-01-07 09:45    [W:0.072 / U:1.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site