lkml.org 
[lkml]   [2020]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 27/74] media: cec: CEC 2.0-only bcast messages were ignored
    Date
    From: Hans Verkuil <hverkuil-cisco@xs4all.nl>

    commit cec935ce69fc386f13959578deb40963ebbb85c3 upstream.

    Some messages are allowed to be a broadcast message in CEC 2.0
    only, and should be ignored by CEC 1.4 devices.

    Unfortunately, the check was wrong, causing such messages to be
    marked as invalid under CEC 2.0.

    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Cc: <stable@vger.kernel.org> # for v4.10 and up
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/media/cec/cec-adap.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    --- a/drivers/media/cec/cec-adap.c
    +++ b/drivers/media/cec/cec-adap.c
    @@ -1031,11 +1031,11 @@ void cec_received_msg_ts(struct cec_adap
    valid_la = false;
    else if (!cec_msg_is_broadcast(msg) && !(dir_fl & DIRECTED))
    valid_la = false;
    - else if (cec_msg_is_broadcast(msg) && !(dir_fl & BCAST1_4))
    + else if (cec_msg_is_broadcast(msg) && !(dir_fl & BCAST))
    valid_la = false;
    else if (cec_msg_is_broadcast(msg) &&
    - adap->log_addrs.cec_version >= CEC_OP_CEC_VERSION_2_0 &&
    - !(dir_fl & BCAST2_0))
    + adap->log_addrs.cec_version < CEC_OP_CEC_VERSION_2_0 &&
    + !(dir_fl & BCAST1_4))
    valid_la = false;
    }
    if (valid_la && min_len) {

    \
     
     \ /
      Last update: 2020-01-07 22:40    [W:4.123 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site