lkml.org 
[lkml]   [2020]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 067/115] riscv: ftrace: correct the condition logic in function graph tracer
    Date
    From: Zong Li <zong.li@sifive.com>

    commit 1d8f65798240b6577d8c44d20c8ea8f1d429e495 upstream.

    The condition should be logical NOT to assign the hook address to parent
    address. Because the return value 0 of function_graph_enter upon
    success.

    Fixes: e949b6db51dc (riscv/function_graph: Simplify with function_graph_enter())
    Signed-off-by: Zong Li <zong.li@sifive.com>
    Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
    Cc: stable@vger.kernel.org
    Signed-off-by: Paul Walmsley <paul.walmsley@sifive.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/riscv/kernel/ftrace.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/riscv/kernel/ftrace.c
    +++ b/arch/riscv/kernel/ftrace.c
    @@ -142,7 +142,7 @@ void prepare_ftrace_return(unsigned long
    */
    old = *parent;

    - if (function_graph_enter(old, self_addr, frame_pointer, parent))
    + if (!function_graph_enter(old, self_addr, frame_pointer, parent))
    *parent = return_hooker;
    }


    \
     
     \ /
      Last update: 2020-01-07 22:11    [W:3.712 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site