lkml.org 
[lkml]   [2020]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/2] net: ethernet: 3c515: Fix cast from pointer to integer of different size
From
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: Sat, 4 Jan 2020 15:33:05 +0100

> Pointer passed as integer should be cast to unsigned long to
> avoid warning (compile testing on alpha architecture):
>
> drivers/net/ethernet/3com/3c515.c: In function ‘corkscrew_start_xmit’:
> drivers/net/ethernet/3com/3c515.c:1066:8: warning:
> cast from pointer to integer of different size [-Wpointer-to-int-cast]
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
> Only compile tested

Sorry, I'm not applying these two.

It is clear that these drivers only work properly on 32-bit architectures
where virtual address equals the DMA address.

Making this warning goes away creates a false sense that they are in
fact 64-bit clean and capable, they are not.
\
 
 \ /
  Last update: 2020-01-06 22:33    [W:0.074 / U:3.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site