lkml.org 
[lkml]   [2020]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 20/20] tools lib: Fix builds when glibc contains strlcpy()
Date
From: Arnaldo Carvalho de Melo
> Sent: 06 January 2020 16:07
>
> From: Vitaly Chikunov <vt@altlinux.org>
>
> Disable a couple of compilation warnings (which are treated as errors)
> on strlcpy() definition and declaration, allowing users to compile perf
> and kernel (objtool) when:
>
> 1. glibc have strlcpy() (such as in ALT Linux since 2004) objtool and
> perf build fails with this (in gcc):
>
> In file included from exec-cmd.c:3:
> tools/include/linux/string.h:20:15: error: redundant redeclaration of ‘strlcpy’ [-Werror=redundant-decls]
> 20 | extern size_t strlcpy(char *dest, const char *src, size_t size);
>
> 2. clang ignores `-Wredundant-decls', but produces another warning when
> building perf:
>
> CC util/string.o
> ../lib/string.c:99:8: error: attribute declaration must precede definition [-Werror,-Wignored-attributes]
> size_t __weak strlcpy(char *dest, const char *src, size_t size)
> ../../tools/include/linux/compiler.h:66:34: note: expanded from macro '__weak'
> # define __weak __attribute__((weak))
> /usr/include/bits/string_fortified.h:151:8: note: previous definition is here
> __NTH (strlcpy (char *__restrict __dest, const char *__restrict __src,

Why not just always use the local version by renaming it?

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
\
 
 \ /
  Last update: 2020-01-06 18:04    [W:0.133 / U:80.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site