Messages in this thread | | | From | Christian Gmeiner <> | Date | Mon, 6 Jan 2020 17:01:11 +0100 | Subject | Re: [PATCH v2 0/6] update hwdw for gc400 |
| |
Hi Sam,
> For future patches can you please incldue a small changelog > within each patch. > > Something like > > v2: > - Drop redundant newlines (Lucas) > > This serves several purposes: > - It explains what was changed since last version > - It allow the reader to focus on changed parts > - It attributes who requested a specific change > - It gives a good idea of the history of a patch > > In the DRM sub-subsystem the idea is that if it is written it > should be visible in git too. So include the changelog part in the > normal commit-message. >
To be honest.. I forgot the change log thing this time - sorry. So the rule is to have the change log in the normal commit message? Funny - Lucas told me something different:
"Please move those changelogs below the 3 dashes, so they don't end up in the commit message. They don't really add any value to the persistent kernel history." https://lkml.org/lkml/2019/9/13/107
-- greets -- Christian Gmeiner, MSc
https://christian-gmeiner.info/privacypolicy
| |