lkml.org 
[lkml]   [2020]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1 1/2] clk: qcom: rpmh: skip undefined clocks when registering
From
Date
Hello Stephen,

Thanks for your review comments.

On 1/2/2020 6:26 AM, Stephen Boyd wrote:
> Quoting Taniya Das (2019-12-31 03:00:47)
>> diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
>> index 7ed313a..05cbe6f 100644
>> --- a/drivers/clk/qcom/clk-rpmh.c
>> +++ b/drivers/clk/qcom/clk-rpmh.c
>> @@ -462,7 +464,8 @@ static int clk_rpmh_probe(struct platform_device *pdev)
>>
>> ret = devm_clk_hw_register(&pdev->dev, hw_clks[i]);
>> if (ret) {
>> - dev_err(&pdev->dev, "failed to register %s\n", name);
>> + dev_err(&pdev->dev, "failed to register %s\n",
>> + hw_clks[i]->init->name);
>
> After register clk_hw::init is NULL. This will probably oops. It would
> be better to save off the name before registering.
>

Will take care in the next patch series.

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--

\
 
 \ /
  Last update: 2020-01-06 11:18    [W:0.068 / U:28.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site