lkml.org 
[lkml]   [2020]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH v7 0/8] add driver for "boe, tv101wum-nl6", "boe, tv101wum-n53", "auo, kd101n80-45na" and "auo, b101uan08.3" panels
Hi Jitao.

On Sat, Oct 12, 2019 at 11:07:12AM +0800, Jitao Shi wrote:
> Changes since v6:
> - fix boe_panel_init err uninit.
> - adjust the delay of backlight on.
>
> Changes since v5:
> - covert the documents to yaml
> - fine tune boe, tv101wum-n53 panel video timine

I finally found some time to looks at this.

The bindings does unfortunately not pass a dt_binding_check

I had to locally do the following to make on of the bindings pass:
diff --git a/Documentation/devicetree/bindings/display/panel/auo,b101uan08.3.yaml b/Documentation/devicetree/bindings/display/panel/auo
,b101uan08.3.yaml
index c0939f8c7274..cafa870120fb 100644
--- a/Documentation/devicetree/bindings/display/panel/auo,b101uan08.3.yaml
+++ b/Documentation/devicetree/bindings/display/panel/auo,b101uan08.3.yaml
@@ -11,6 +11,9 @@ maintainers:
- Sam Ravnborg <sam@ravnborg.org>
- Rob Herring <robh+dt@kernel.org>

+allOf:
+ - $ref: panel-common.yaml#
+
properties:
compatible:
const: auo,b101uan08.3
@@ -33,6 +36,8 @@ properties:
backlight:
description: phandle of the backlight device attached to the panel

+ port: true
+
required:
- compatible
- reg
@@ -46,7 +51,9 @@ additionalProperties: false

examples:
- |
- &dsi {
+ dsi {
+ #address-cells = <1>;
+ #size-cells = <0>;
panel@0 {
compatible = "auo,b101uan08.3";
reg = <0>;
I will follow-up with review feedback on the drivers later as time
permits.

Sam



\
 
 \ /
  Last update: 2020-01-05 12:06    [W:0.088 / U:1.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site