Messages in this thread | | | From | Chaitanya Kulkarni <> | Subject | Re: [resend v1 4/5] drivers/nvme/host/core.c: Convert to use disk_set_capacity | Date | Sat, 4 Jan 2020 22:27:39 +0000 |
| |
Quick question here if user executes nvme ns-rescan /dev/nvme1 will following code result in triggering uevent(s) for the namespace(s( for which there is no change in the size ?
If so is that an expected behavior ?
On 01/01/2020 11:54 PM, Balbir Singh wrote: > block/genhd provides disk_set_capacity() for sending > RESIZE notifications via uevents. This notification is > newly added to NVME devices > > Signed-off-by: Balbir Singh <sblbir@amazon.com> > --- > drivers/nvme/host/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c > index 667f18f465be..cb214e914fc2 100644 > --- a/drivers/nvme/host/core.c > +++ b/drivers/nvme/host/core.c > @@ -1808,7 +1808,7 @@ static void nvme_update_disk_info(struct gendisk *disk, > ns->lba_shift > PAGE_SHIFT) > capacity = 0; > > - set_capacity(disk, capacity); > + disk_set_capacity(disk, capacity); > > nvme_config_discard(disk, ns); > nvme_config_write_zeroes(disk, ns); >
| |