lkml.org 
[lkml]   [2020]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] mtd: onenand: omap2: Pass correct flags for prep_dma_memcpy
    Hi,

    On Sat, Jan 04, 2020 at 09:34:53AM +0200, Peter Ujfalusi wrote:
    > The commit converting the driver to DMAengine was missing the flags for
    > the memcpy prepare call.
    > It went unnoticed since the omap-dma drive was ignoring them.
    >
    > Fixes: 3ed6a4d1de2c5 (" mtd: onenand: omap2: Convert to use dmaengine for memcp")
    > Reported-by: Aaro Koskinen <aaro.koskinen@iki.fi>
    > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
    > ---
    > Hi,
    >
    > Aaro reported [1] a failure on omap2-onenand pointing to
    > 4689d35c765c696bdf0535486a990038b242a26b. It looks like the root cause is the
    > conversion of omap2-onenand to DMAengine which missed the flags.
    >
    > Basically the client is waiting for a callback without asking for it. This
    > certainly causes timeout.
    >
    > I have not tested the patch, but it should fix the issue.

    This fixes the issue on Nokia boards.

    Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi>

    Thanks,

    A.

    \
     
     \ /
      Last update: 2020-01-04 21:29    [W:4.978 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site