lkml.org 
[lkml]   [2020]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: most: remove header include path to drivers/staging
On Sun, Jan 05, 2020 at 01:18:27AM +0900, Masahiro Yamada wrote:
> There is no need to add "ccflags-y += -I $(srctree)/drivers/staging"
> just for including <most/core.h>.
>
> Use the #include "..." directive with the correct relative path.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> drivers/staging/most/Makefile | 1 -
> drivers/staging/most/cdev/Makefile | 1 -
> drivers/staging/most/cdev/cdev.c | 3 ++-
> drivers/staging/most/configfs.c | 3 ++-
> drivers/staging/most/core.c | 3 ++-
> drivers/staging/most/dim2/Makefile | 1 -
> drivers/staging/most/dim2/dim2.c | 2 +-
> drivers/staging/most/i2c/Makefile | 1 -
> drivers/staging/most/i2c/i2c.c | 2 +-
> drivers/staging/most/net/Makefile | 1 -
> drivers/staging/most/net/net.c | 3 ++-
> drivers/staging/most/sound/Makefile | 1 -
> drivers/staging/most/sound/sound.c | 3 ++-
> drivers/staging/most/usb/Makefile | 1 -
> drivers/staging/most/usb/usb.c | 3 ++-
> drivers/staging/most/video/Makefile | 1 -
> drivers/staging/most/video/video.c | 2 +-
> 17 files changed, 15 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/staging/most/Makefile b/drivers/staging/most/Makefile
> index 85ea5a434ced..20a99ecb37c4 100644
> --- a/drivers/staging/most/Makefile
> +++ b/drivers/staging/most/Makefile
> @@ -2,7 +2,6 @@
> obj-$(CONFIG_MOST) += most_core.o
> most_core-y := core.o
> most_core-y += configfs.o
> -ccflags-y += -I $(srctree)/drivers/staging/
>
> obj-$(CONFIG_MOST_CDEV) += cdev/
> obj-$(CONFIG_MOST_NET) += net/

This all was done on purpose to make a follow-on patch much simpler that
I didn't end up taking as it still needed more work.

But I do agree with it, we shouldn't be abusing ccflags here, I'll go
queue this up in a day or so, thanks for this.

greg k-h

\
 
 \ /
  Last update: 2020-01-04 19:12    [W:0.033 / U:41.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site