lkml.org 
[lkml]   [2020]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] hwmon: (pmbus/ibm-cffps) Fix the LED behavior when turned off
On Thu, Dec 19, 2019 at 02:50:07PM -0600, Eddie James wrote:
> The driver should remain in control of the LED on the PSU, even while
> off, not the PSU firmware as previously indicated.
>
> Signed-off-by: Eddie James <eajames@linux.ibm.com>

Applied to hwmon-next.

Thanks,
Guenter

> ---
> drivers/hwmon/pmbus/ibm-cffps.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/hwmon/pmbus/ibm-cffps.c b/drivers/hwmon/pmbus/ibm-cffps.c
> index b37faf1..1c91ee1 100644
> --- a/drivers/hwmon/pmbus/ibm-cffps.c
> +++ b/drivers/hwmon/pmbus/ibm-cffps.c
> @@ -47,13 +47,9 @@
> #define CFFPS_MFR_VAUX_FAULT BIT(6)
> #define CFFPS_MFR_CURRENT_SHARE_WARNING BIT(7)
>
> -/*
> - * LED off state actually relinquishes LED control to PSU firmware, so it can
> - * turn on the LED for faults.
> - */
> -#define CFFPS_LED_OFF 0
> #define CFFPS_LED_BLINK BIT(0)
> #define CFFPS_LED_ON BIT(1)
> +#define CFFPS_LED_OFF BIT(2)
> #define CFFPS_BLINK_RATE_MS 250
>
> enum {
> @@ -436,6 +432,9 @@ static void ibm_cffps_create_led_class(struct ibm_cffps *psu)
> rc = devm_led_classdev_register(dev, &psu->led);
> if (rc)
> dev_warn(dev, "failed to register led class: %d\n", rc);
> + else
> + i2c_smbus_write_byte_data(client, CFFPS_SYS_CONFIG_CMD,
> + CFFPS_LED_OFF);
> }
>
> static struct pmbus_driver_info ibm_cffps_info[] = {

\
 
 \ /
  Last update: 2020-01-04 17:31    [W:0.046 / U:2.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site