lkml.org 
[lkml]   [2020]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v9 12/13] exfat: add exfat in fs/Kconfig and fs/Makefile
Hi Namjae,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linux/master]
[also build test ERROR on hch-configfs/for-next linus/master v5.5-rc4 next-20191219]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Namjae-Jeon/add-the-latest-exfat-driver/20200104-035709
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 1522d9da40bdfe502c91163e6d769332897201fa
config: c6x-allyesconfig (attached as .config)
compiler: c6x-elf-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=c6x

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

fs/exfat/misc.c: In function 'exfat_time_unix2fat':
>> fs/exfat/misc.c:157:16: error: 'UNIX_SECS_2108' undeclared (first use in this function); did you mean 'UNIX_SECS_1980'?
if (second >= UNIX_SECS_2108) {
^~~~~~~~~~~~~~
UNIX_SECS_1980
fs/exfat/misc.c:157:16: note: each undeclared identifier is reported only once for each function it appears in

vim +157 fs/exfat/misc.c

25430145db94f9 Namjae Jeon 2020-01-02 131
25430145db94f9 Namjae Jeon 2020-01-02 132 #define TIMEZONE_CUR_OFFSET() ((sys_tz.tz_minuteswest / (-15)) & 0x7F)
25430145db94f9 Namjae Jeon 2020-01-02 133 /* Convert linear UNIX date to a FAT time/date pair. */
25430145db94f9 Namjae Jeon 2020-01-02 134 void exfat_time_unix2fat(struct exfat_sb_info *sbi, struct timespec64 *ts,
25430145db94f9 Namjae Jeon 2020-01-02 135 struct exfat_date_time *tp)
25430145db94f9 Namjae Jeon 2020-01-02 136 {
25430145db94f9 Namjae Jeon 2020-01-02 137 time_t second = ts->tv_sec;
25430145db94f9 Namjae Jeon 2020-01-02 138 time_t day, month, year;
25430145db94f9 Namjae Jeon 2020-01-02 139 time_t ld; /* leap day */
25430145db94f9 Namjae Jeon 2020-01-02 140
25430145db94f9 Namjae Jeon 2020-01-02 141 /* Treats as local time with proper time */
25430145db94f9 Namjae Jeon 2020-01-02 142 second -= sys_tz.tz_minuteswest * SECS_PER_MIN;
25430145db94f9 Namjae Jeon 2020-01-02 143 tp->timezone.valid = 1;
25430145db94f9 Namjae Jeon 2020-01-02 144 tp->timezone.off = TIMEZONE_CUR_OFFSET();
25430145db94f9 Namjae Jeon 2020-01-02 145
25430145db94f9 Namjae Jeon 2020-01-02 146 /* Jan 1 GMT 00:00:00 1980. But what about another time zone? */
25430145db94f9 Namjae Jeon 2020-01-02 147 if (second < UNIX_SECS_1980) {
25430145db94f9 Namjae Jeon 2020-01-02 148 tp->second = 0;
25430145db94f9 Namjae Jeon 2020-01-02 149 tp->minute = 0;
25430145db94f9 Namjae Jeon 2020-01-02 150 tp->hour = 0;
25430145db94f9 Namjae Jeon 2020-01-02 151 tp->day = 1;
25430145db94f9 Namjae Jeon 2020-01-02 152 tp->month = 1;
25430145db94f9 Namjae Jeon 2020-01-02 153 tp->year = 0;
25430145db94f9 Namjae Jeon 2020-01-02 154 return;
25430145db94f9 Namjae Jeon 2020-01-02 155 }
25430145db94f9 Namjae Jeon 2020-01-02 156
25430145db94f9 Namjae Jeon 2020-01-02 @157 if (second >= UNIX_SECS_2108) {
25430145db94f9 Namjae Jeon 2020-01-02 158 tp->second = 59;
25430145db94f9 Namjae Jeon 2020-01-02 159 tp->minute = 59;
25430145db94f9 Namjae Jeon 2020-01-02 160 tp->hour = 23;
25430145db94f9 Namjae Jeon 2020-01-02 161 tp->day = 31;
25430145db94f9 Namjae Jeon 2020-01-02 162 tp->month = 12;
25430145db94f9 Namjae Jeon 2020-01-02 163 tp->year = 127;
25430145db94f9 Namjae Jeon 2020-01-02 164 return;
25430145db94f9 Namjae Jeon 2020-01-02 165 }
25430145db94f9 Namjae Jeon 2020-01-02 166
25430145db94f9 Namjae Jeon 2020-01-02 167 day = second / SECS_PER_DAY - DAYS_DELTA_DECADE;
25430145db94f9 Namjae Jeon 2020-01-02 168 year = day / 365;
25430145db94f9 Namjae Jeon 2020-01-02 169
25430145db94f9 Namjae Jeon 2020-01-02 170 MAKE_LEAP_YEAR(ld, year);
25430145db94f9 Namjae Jeon 2020-01-02 171 if (year * 365 + ld > day)
25430145db94f9 Namjae Jeon 2020-01-02 172 year--;
25430145db94f9 Namjae Jeon 2020-01-02 173
25430145db94f9 Namjae Jeon 2020-01-02 174 MAKE_LEAP_YEAR(ld, year);
25430145db94f9 Namjae Jeon 2020-01-02 175 day -= year * 365 + ld;
25430145db94f9 Namjae Jeon 2020-01-02 176
25430145db94f9 Namjae Jeon 2020-01-02 177 if (IS_LEAP_YEAR(year) && day == accum_days_in_year[3]) {
25430145db94f9 Namjae Jeon 2020-01-02 178 month = 2;
25430145db94f9 Namjae Jeon 2020-01-02 179 } else {
25430145db94f9 Namjae Jeon 2020-01-02 180 if (IS_LEAP_YEAR(year) && day > accum_days_in_year[3])
25430145db94f9 Namjae Jeon 2020-01-02 181 day--;
25430145db94f9 Namjae Jeon 2020-01-02 182 for (month = 1; month < 12; month++) {
25430145db94f9 Namjae Jeon 2020-01-02 183 if (accum_days_in_year[month + 1] > day)
25430145db94f9 Namjae Jeon 2020-01-02 184 break;
25430145db94f9 Namjae Jeon 2020-01-02 185 }
25430145db94f9 Namjae Jeon 2020-01-02 186 }
25430145db94f9 Namjae Jeon 2020-01-02 187 day -= accum_days_in_year[month];
25430145db94f9 Namjae Jeon 2020-01-02 188
25430145db94f9 Namjae Jeon 2020-01-02 189 tp->second = second % SECS_PER_MIN;
25430145db94f9 Namjae Jeon 2020-01-02 190 tp->minute = (second / SECS_PER_MIN) % 60;
25430145db94f9 Namjae Jeon 2020-01-02 191 tp->hour = (second / SECS_PER_HOUR) % 24;
25430145db94f9 Namjae Jeon 2020-01-02 192 tp->day = day + 1;
25430145db94f9 Namjae Jeon 2020-01-02 193 tp->month = month;
25430145db94f9 Namjae Jeon 2020-01-02 194 tp->year = year;
25430145db94f9 Namjae Jeon 2020-01-02 195 }
25430145db94f9 Namjae Jeon 2020-01-02 196

:::::: The code at line 157 was first introduced by commit
:::::: 25430145db94f9ef1c017b0b2e3f4729888576d7 exfat: add misc operations

:::::: TO: Namjae Jeon <namjae.jeon@samsung.com>
:::::: CC: 0day robot <lkp@intel.com>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2020-01-04 06:24    [W:0.341 / U:3.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site