Messages in this thread | | | Date | Fri, 31 Jan 2020 16:25:42 -0800 | From | Matthew Wilcox <> | Subject | Re: [PATCH 04/12] mm: Add readahead address space operation |
| |
On Fri, Jan 24, 2020 at 07:57:40PM -0800, Randy Dunlap wrote: > > +``readahead`` > > + called by the VM to read pages associated with the address_space > > + object. The pages are consecutive in the page cache and are > > + locked. The implementation should decrement the page refcount after > > + attempting I/O on each page. Usually the page will be unlocked by > > + the I/O completion handler. If the function does not attempt I/O on > > + some pages, return the number of pages which were not read so the > > + common code can unlock the pages for you. > > + > > Please use consistent indentation (tabs).
This turned out to be not my fault. The vim rst ... mode? plugin? Whatever it is, it's converting tabs to spaces! To fix it, I had to rename the file to .txt, make the edits, then rename it back. This is very poor behaviour.
| |