Messages in this thread Patch in this message | | | From | Jules Irenge <> | Subject | [PATCH 3/3] futex: Add missing annotation for fixup_pi_state_owner() | Date | Sat, 1 Feb 2020 00:04:16 +0000 |
| |
Sparse reports a warning at fixup_pi_state_owner()
warning: context imbalance in fixup_pi_state_owner() - unexpected unlock
The root cause is a missing annotation of fixup_pi_state_owner().
Add the missing __must_hold(q->lock_ptr) annotation
Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- kernel/futex.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/kernel/futex.c b/kernel/futex.c index 93e7510a5b36..5263cce46c06 100644 --- a/kernel/futex.c +++ b/kernel/futex.c @@ -2440,6 +2440,7 @@ static void unqueue_me_pi(struct futex_q *q) static int fixup_pi_state_owner(u32 __user *uaddr, struct futex_q *q, struct task_struct *argowner) + __must_hold(q->lock_ptr) { struct futex_pi_state *pi_state = q->pi_state; u32 uval, uninitialized_var(curval), newval; -- 2.24.1
| |