Messages in this thread | | | Date | Fri, 31 Jan 2020 09:40:56 -0800 | From | Davidlohr Bueso <> | Subject | Re: [PATCH RFC locktorture] Print ratio of acquisitions, not failures |
| |
On Thu, 23 Jan 2020, Paul E. McKenney wrote:
>The __torture_print_stats() function in locktorture.c carefully >initializes local variable "min" to statp[0].n_lock_acquired, but >then compares it to statp[i].n_lock_fail. Given that the .n_lock_fail >field should normally be zero, and given the initialization, it seems >reasonable to display the maximum and minimum number acquisitions >instead of miscomputing the maximum and minimum number of failures. >This commit therefore switches from failures to acquisitions.
This makes sense, thanks!
> >Reported-by: Will Deacon <will@kernel.org> >Signed-off-by: Paul E. McKenney <paulmck@kernel.org> >Cc: Davidlohr Bueso <dave@stgolabs.net> >Cc: Josh Triplett <josh@joshtriplett.org> >Cc: Peter Zijlstra <peterz@infradead.org>
Acked-by: Davidlohr Bueso <dbueso@suse.de>
| |