lkml.org 
[lkml]   [2020]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 068/110] net: wan: sdla: Fix cast from pointer to integer of different size
    Date
    From: Krzysztof Kozlowski <krzk@kernel.org>

    [ Upstream commit 00c0688cecadbf7ac2f5b4cdb36d912a2d3f0cca ]

    Since net_device.mem_start is unsigned long, it should not be cast to
    int right before casting to pointer. This fixes warning (compile
    testing on alpha architecture):

    drivers/net/wan/sdla.c: In function ‘sdla_transmit’:
    drivers/net/wan/sdla.c:711:13: warning:
    cast to pointer from integer of different size [-Wint-to-pointer-cast]

    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wan/sdla.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/wan/sdla.c b/drivers/net/wan/sdla.c
    index e2e679a01b65a..77ccf3672ede7 100644
    --- a/drivers/net/wan/sdla.c
    +++ b/drivers/net/wan/sdla.c
    @@ -708,7 +708,7 @@ static netdev_tx_t sdla_transmit(struct sk_buff *skb,

    spin_lock_irqsave(&sdla_lock, flags);
    SDLA_WINDOW(dev, addr);
    - pbuf = (void *)(((int) dev->mem_start) + (addr & SDLA_ADDR_MASK));
    + pbuf = (void *)(dev->mem_start + (addr & SDLA_ADDR_MASK));
    __sdla_write(dev, pbuf->buf_addr, skb->data, skb->len);
    SDLA_WINDOW(dev, addr);
    pbuf->opp_flag = 1;
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-30 19:52    [W:4.162 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site