lkml.org 
[lkml]   [2020]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 4/8] dt-bindings: phy: qcom-qusb2: Add support for overriding Phy tuning parameters
    On Wed, Jan 29, 2020 at 07:21:55PM +0530, Sandeep Maheswaram wrote:
    > Add support for overriding QUSB2 V2 phy tuning parameters
    > in device tree bindings.
    >
    > Signed-off-by: Sandeep Maheswaram <sanm@codeaurora.org>
    > Reviewed-by: Rob Herring <robh@kernel.org>
    > ---
    > .../devicetree/bindings/phy/qcom,qusb2-phy.yaml | 33 ++++++++++++++++++++++
    > 1 file changed, 33 insertions(+)
    >
    > diff --git a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
    > index 43082c8..dfef356 100644
    > --- a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
    > +++ b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
    > @@ -80,6 +80,28 @@ properties:
    > maximum: 63
    > default: 0
    >
    > + qcom,bias-ctrl-value:
    > + description:
    > + It is a 6 bit value that specifies bias-ctrl-value. It is a PHY
    > + tuning parameter that may vary for different boards of same SOC.
    > + This property is applicable to only QUSB2 v2 PHY.

    As commented on 'dt-bindings: phy: qcom,qusb2: Convert QUSB2 phy bindings
    to yaml' a possible improvement could be to restrict these properties to
    the QUSB2 v2 PHY through the schema.

    > + allOf:
    > + - $ref: /schemas/types.yaml#/definitions/uint32
    > + - minimum: 0
    > + maximum: 63
    > + default: 0
    > +
    > + qcom,charge-ctrl-value:
    > + description:
    > + It is a 2 bit value that specifies charge-ctrl-value. It is a PHY
    > + tuning parameter that may vary for different boards of same SOC.
    > + This property is applicable to only QUSB2 v2 PHY.
    > + allOf:
    > + - $ref: /schemas/types.yaml#/definitions/uint32
    > + - minimum: 0
    > + maximum: 3
    > + default: 0
    > +
    > qcom,hstx-trim-value:
    > description:
    > It is a 4 bit value that specifies tuning for HSTX
    > @@ -118,6 +140,17 @@ properties:
    > maximum: 1
    > default: 0
    >
    > + qcom,hsdisc-trim-value:
    > + description:
    > + It is a 2 bit value tuning parameter that control disconnect
    > + threshold and may vary for different boards of same SOC.
    > + This property is applicable to only QUSB2 v2 PHY.
    > + allOf:
    > + - $ref: /schemas/types.yaml#/definitions/uint32
    > + - minimum: 0
    > + maximum: 3
    > + default: 0
    > +
    > required:
    > - compatible
    > - reg

    Reviewed-by: Matthias Kaehlcke <mka@chromium.org>

    \
     
     \ /
      Last update: 2020-01-29 21:39    [W:2.142 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site