lkml.org 
[lkml]   [2020]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 14/28] ata: move ata_dev_config_ncq*() to libata-core-sata.c
On Tue, Jan 28, 2020 at 02:33:29PM +0100, Bartlomiej Zolnierkiewicz wrote:
> * move ata_log_supported() to libata.h and make it inline
>
> * move ata_dev_config_ncq*() to libata-core-sata.c
>
> * add static inline version of ata_dev_config_ncq() for
> CONFIG_SATA_HOST=n case

Wouldn't it be easier to throw in an IS_ENABLED() into the
ATA_FLAG_FPDMA_AUX before calling ata_dev_config_ncq_* and let the
compiler optimize out the functions?

\
 
 \ /
  Last update: 2020-01-29 18:30    [W:0.168 / U:0.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site