Messages in this thread | | | Date | Wed, 29 Jan 2020 09:24:48 -0800 | From | Christoph Hellwig <> | Subject | Re: [PATCH 11/28] ata: add CONFIG_SATA_HOST=n version of ata_ncq_enabled() |
| |
> static inline int ata_ncq_enabled(struct ata_device *dev) > { > +#ifdef CONFIG_SATA_HOST > return (dev->flags & (ATA_DFLAG_PIO | ATA_DFLAG_NCQ_OFF | > ATA_DFLAG_NCQ)) == ATA_DFLAG_NCQ; > +#else > + return 0; > +#endif
I think this is a prime candidate for IS_ENABLED:
if (!IS_ENABLED(CONFIG_SATA_HOST)) return 0; return (dev->flags & (ATA_DFLAG_PIO | ATA_DFLAG_NCQ_OFF | ATA_DFLAG_NCQ)) == ATA_DFLAG_NCQ;
| |