Messages in this thread | | | From | Arnd Bergmann <> | Date | Tue, 28 Jan 2020 14:07:51 +0100 | Subject | Re: [PATCH] drm/etnaviv: only reject timeouts with tv_nsec >= 2 seconds |
| |
On Fri, Jan 24, 2020 at 9:56 AM Guido Günther <agx@sigxcpu.org> wrote: > On Wed, Jan 22, 2020 at 10:35:53AM +0000, Russell King - ARM Linux admin wrote: > > On Wed, Jan 22, 2020 at 11:30:34AM +0100, Guido Günther wrote:
> > I think it would probably be better for the kernel to print a > > warning once when noticing over-large nsec values, suggesting a > > userspace upgrade is in order, but continue the existing behaviour. > > That makes sense to me. This also makes sure we don't break other (non > mesa using) stuff accidentally. We have > > https://gitlab.freedesktop.org/mesa/mesa/commit/d817f2c69615cf37b78f484a25b7831ebe9dbe6f > > and > > https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3534 > > to normalize nsec to [0..999999999] now. >
I have reverted my patch that adds the range check now, so I can send the rest of the series for inclusion.
I've played around with ways to add a ratelimited warning message and to make sure that a malicious application cannot cause a long stall, but haven't managed to get a version I'm actually happy with.
I'll follow up once the series is merged, and then we can add a better workaround later through the drm tree.
Arnd
| |