lkml.org 
[lkml]   [2020]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC PATCH v1 3/5] dt-binding: tegra: Add VI and CSI bindings
    From
    Date
    Hi,

    On 1/28/20 4:23 PM, Sowjanya Komatineni wrote:
    > Tegra contains VI controller which can support up to 6 MIPI CSI
    > camera sensors.
    >
    > Each Tegra CSI port from CSI unit can be one-to-one mapper to
    > VI channel and can capture from an external camera sensor or
    > from built-in test pattern generator.
    >
    > This patch adds dt-bindings for Tegra VI and CSI.
    >
    > Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
    > ---
    > .../bindings/display/tegra/nvidia,tegra20-host1x.txt | 10 +++++++++-
    > 1 file changed, 9 insertions(+), 1 deletion(-)
    >
    > diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.txt b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.txt
    > index 9999255ac5b6..47cd6532b7d3 100644
    > --- a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.txt
    > +++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.txt
    > @@ -40,7 +40,7 @@ of the following host1x client modules:
    >
    > Required properties:
    > - compatible: "nvidia,tegra<chip>-vi"
    > - - reg: Physical base address and length of the controller's registers.
    > + - reg: Physical base address and length of the controller registers.
    > - interrupts: The interrupt outputs from the controller.
    > - clocks: Must contain one entry, for the module clock.
    > See ../clocks/clock-bindings.txt for details.
    > @@ -49,6 +49,14 @@ of the following host1x client modules:
    > - reset-names: Must include the following entries:
    > - vi
    >
    > +- csi: mipi csi interface to vi
    > +
    > + Required properties:
    > + - compatible: "nvidia,tegra<chip>-csi"
    > + - reg: Physical base address and length of the controller registers.
    > + - clocks: Must contain entries csi, cilab, cilcd, cile clocks.
    > + See ../clocks/clock-bindings.txt for details.
    > +

    I think it would be nice to add an example, in the Example section at the end of this file, same as other modules do.

    Regards,
    Helen

    > - epp: encoder pre-processor
    >
    > Required properties:
    >

    \
     
     \ /
      Last update: 2020-01-28 21:33    [W:5.069 / U:1.368 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site