lkml.org 
[lkml]   [2020]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 048/104] Revert "iwlwifi: mvm: fix scan config command size"
    Date
    From: Mehmet Akif Tasova <makiftasova@gmail.com>

    commit 205608749e1ef394f513888091e613c5bfccbcca upstream.

    Since v5.4-rc1 was released, iwlwifi started throwing errors when scan
    commands were sent to the firmware with certain devices (depending on
    the OTP burned in the device, which contains the list of available
    channels). For instance:

    iwlwifi 0000:00:14.3: FW error in SYNC CMD SCAN_CFG_CMD

    This bug was reported in the ArchLinux bug tracker:
    https://bugs.archlinux.org/task/64703

    And also in a specific case in bugzilla, when the lar_disabled option
    was set: https://bugzilla.kernel.org/show_bug.cgi?id=205193

    Revert the commit that introduced this error, by using the number of
    channels from the OTP instead of the number of channels that is
    specified in the FW TLV that tells us how many channels it supports.

    This reverts commit 06eb547c4ae4382e70d556ba213d13c95ca1801b.

    Cc: stable@vger.kernel.org # v5.4+
    Signed-off-by: Mehmet Akif Tasova <makiftasova@gmail.com>
    [ Luca: reworded the commit message a bit. ]
    Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/wireless/intel/iwlwifi/mvm/scan.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
    +++ b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
    @@ -1220,7 +1220,7 @@ static int iwl_mvm_legacy_config_scan(st
    cmd_size = sizeof(struct iwl_scan_config_v2);
    else
    cmd_size = sizeof(struct iwl_scan_config_v1);
    - cmd_size += num_channels;
    + cmd_size += mvm->fw->ucode_capa.n_scan_channels;

    cfg = kzalloc(cmd_size, GFP_KERNEL);
    if (!cfg)

    \
     
     \ /
      Last update: 2020-01-28 15:48    [W:4.330 / U:0.312 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site