lkml.org 
[lkml]   [2020]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [alsa-devel] [PATCH 2/9] ASoC: tegra: add support for CIF programming
    From
    Date


    On 1/21/2020 9:34 PM, Dmitry Osipenko wrote:
    > External email: Use caution opening links or attachments
    >
    >
    > 21.01.2020 07:41, Sameer Pujar пишет:
    >> On 1/20/2020 9:28 PM, Dmitry Osipenko wrote:
    >>> External email: Use caution opening links or attachments
    >>>
    >>>
    >>> Hello Sameer,
    >>>
    >>> 20.01.2020 17:23, Sameer Pujar пишет:
    >>>
    >>> [snip]
    >>>
    >>>> Tegra30 and Tegra124 have an identical CIF programming helper function.
    >>> [snip]
    >>>
    >>>> -#define TEGRA124_AUDIOCIF_CTRL_FIFO_THRESHOLD_SHIFT 24
    >>>> -#define TEGRA124_AUDIOCIF_CTRL_FIFO_THRESHOLD_MASK_US 0x3f
    >>>> -#define TEGRA124_AUDIOCIF_CTRL_FIFO_THRESHOLD_MASK
    >>>> (TEGRA124_AUDIOCIF_CTRL_FIFO_THRESHOLD_MASK_US <<
    >>>> TEGRA124_AUDIOCIF_CTRL_FIFO_THRESHOLD_SHIFT)
    >>>> -
    >>>> -/* Channel count minus 1 */
    >>>> -#define TEGRA30_AUDIOCIF_CTRL_AUDIO_CHANNELS_SHIFT 24
    >>>> -#define TEGRA30_AUDIOCIF_CTRL_AUDIO_CHANNELS_MASK_US 7
    >>>> -#define TEGRA30_AUDIOCIF_CTRL_AUDIO_CHANNELS_MASK
    >>>> (TEGRA30_AUDIOCIF_CTRL_AUDIO_CHANNELS_MASK_US <<
    >>>> TEGRA30_AUDIOCIF_CTRL_AUDIO_CHANNELS_SHIFT)
    >>> The AUDIOCIF_CTRL bitfields are not the same on T30 and T124, why are
    >>> you claiming that programming is identical? Have you actually tried to
    >>> test these patches on T30?
    >> Oh yes! seems like I overlooked the macro values. Thanks for pointing
    >> this. I will retain separate CIF function for Tegra30.
    >> I do not have a Tegra30 board with me and hence could not test anything
    >> specific to it apart from build sanity.
    >> If someone can help me test I would really appreciate.
    >>
    > I'll help with the testing once all obvious problems will be fixed.

    Thanks Dmitry. However I plan to send Tegra30 related patch separately.
    In this series I will focus on Tegra210 and later.

    \
     
     \ /
      Last update: 2020-01-27 06:11    [W:4.094 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site