Messages in this thread | | | Date | Mon, 27 Jan 2020 11:32:39 +0100 (CET) | Subject | Re: [PATCH net-next 0/7] ethtool netlink interface, part 2 | From | David Miller <> |
| |
From: Michal Kubecek <mkubecek@suse.cz> Date: Mon, 27 Jan 2020 10:57:44 +0100
> On Mon, Jan 27, 2020 at 10:40:49AM +0100, David Miller wrote: >> From: Michal Kubecek <mkubecek@suse.cz> >> Date: Sun, 26 Jan 2020 23:10:58 +0100 (CET) >> >> > This shorter series adds support for getting and setting of wake-on-lan >> > settings and message mask (originally message level). Together with the >> > code already in net-next, this will allow full implementation of >> > "ethtool <dev>" and "ethtool -s <dev> ...". >> > >> > Older versions of the ethtool netlink series allowed getting WoL settings >> > by unprivileged users and only filtered out the password but this was >> > a source of controversy so for now, ETHTOOL_MSG_WOL_GET request always >> > requires CAP_NET_ADMIN as ETHTOOL_GWOL ioctl request does. >> >> It looks like this will need to be respun at least once, and net-next >> is closing today so.... > > The problem with ethnl_parse_header() name not making it obvious that it > takes a reference is not introduced in this series, the function is > already in net-next so that it does not matter if this series is merged > or not. Other than that, there is only the missing "the" in > documentation.
Ok, looks good, series applied.
Thanky you.
| |