Messages in this thread | | | Date | Sun, 26 Jan 2020 10:39:32 +0100 | From | Stanislaw Gruszka <> | Subject | Re: [PATCH][next] iwlegacy: ensure loop counter addr does not wrap and cause an infinite loop |
| |
On Sun, Jan 26, 2020 at 12:09:54AM +0000, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The loop counter addr is a u16 where as the upper limit of the loop > is a an int. In the unlikely event that the il->cfg->eeprom_size is > greater than 64K then we end up with an infinite loop since addr will > wrap around an never reach upper loop limit. Fix this by making addr > an int. > > Addresses-Coverity: ("Infinite loop") > Fixes: be663ab67077 ("iwlwifi: split the drivers for agn and legacy devices 3945/4965") > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
| |