lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 096/639] pinctrl: sh-pfc: sh7734: Remove bogus IPSR10 value
    Date
    From: Geert Uytterhoeven <geert+renesas@glider.be>

    [ Upstream commit 4d374bacd7c9665179f9752a52d5d602c45d8190 ]

    The IP10[5:3] field in Peripheral Function Select Register 10 has a
    width of 3 bits, i.e. it allows programming one out of 8 different
    configurations.
    However, 9 values are provided instead of 8, overflowing into the
    subsequent field in the register, and thus breaking the configuration of
    the latter.

    Fix this by dropping a bogus zero value.

    Fixes: ac1ebc2190f575fc ("sh-pfc: Add sh7734 pinmux support")
    Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pinctrl/sh-pfc/pfc-sh7734.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/pinctrl/sh-pfc/pfc-sh7734.c b/drivers/pinctrl/sh-pfc/pfc-sh7734.c
    index 05ccb27f77818..c691e5e9d9dea 100644
    --- a/drivers/pinctrl/sh-pfc/pfc-sh7734.c
    +++ b/drivers/pinctrl/sh-pfc/pfc-sh7734.c
    @@ -2231,7 +2231,7 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = {
    FN_LCD_CL1_B, 0, 0,
    /* IP10_5_3 [3] */
    FN_SSI_WS23, FN_VI1_5_B, FN_TX1_D, FN_HSCK0_C, FN_FALE_B,
    - FN_LCD_DON_B, 0, 0, 0,
    + FN_LCD_DON_B, 0, 0,
    /* IP10_2_0 [3] */
    FN_SSI_SCK23, FN_VI1_4_B, FN_RX1_D, FN_FCLE_B,
    FN_LCD_DATA15_B, 0, 0, 0 }
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:05    [W:4.214 / U:1.252 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site