lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 305/343] RDMA/cma: Fix false error message
    Date
    From: Håkon Bugge <haakon.bugge@oracle.com>

    [ Upstream commit a6e4d254c19b541a58caced322111084b27a7788 ]

    In addr_handler(), assuming status == 0 and the device already has been
    acquired (id_priv->cma_dev != NULL), we get the following incorrect
    "error" message:

    RDMA CM: ADDR_ERROR: failed to resolve IP. status 0

    Fixes: 498683c6a7ee ("IB/cma: Add debug messages to error flows")
    Link: https://lore.kernel.org/r/20190902092731.1055757-1-haakon.bugge@oracle.com
    Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
    Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/infiniband/core/cma.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
    index fc4630e4acdd6..1614f6f3677c0 100644
    --- a/drivers/infiniband/core/cma.c
    +++ b/drivers/infiniband/core/cma.c
    @@ -2789,7 +2789,7 @@ static void addr_handler(int status, struct sockaddr *src_addr,
    if (status)
    pr_debug_ratelimited("RDMA CM: ADDR_ERROR: failed to acquire device. status %d\n",
    status);
    - } else {
    + } else if (status) {
    pr_debug_ratelimited("RDMA CM: ADDR_ERROR: failed to resolve IP. status %d\n", status);
    }

    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 11:07    [W:4.177 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site