lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 109/343] hwmon: (pmbus/tps53679) Fix driver info initialization in probe routine
    Date
    From: Vadim Pasternak <vadimp@mellanox.com>

    [ Upstream commit ff066653aeed8ee2d4dadb1e35774dd91ecbb19f ]

    Fix tps53679_probe() by using dynamically allocated "pmbus_driver_info"
    structure instead of static. Usage of static structures causes
    overwritten of the field "vrm_version", in case the system is equipped
    with several tps53679 devices with the different "vrm_version".
    In such case the last probed device overwrites this field for all
    others.

    Fixes: 610526527a13 ("hwmon: (pmbus) Add support for Texas Instruments tps53679 device")
    Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/hwmon/pmbus/tps53679.c | 9 ++++++++-
    1 file changed, 8 insertions(+), 1 deletion(-)

    diff --git a/drivers/hwmon/pmbus/tps53679.c b/drivers/hwmon/pmbus/tps53679.c
    index 85b515cd9df0e..2bc352c5357f4 100644
    --- a/drivers/hwmon/pmbus/tps53679.c
    +++ b/drivers/hwmon/pmbus/tps53679.c
    @@ -80,7 +80,14 @@ static struct pmbus_driver_info tps53679_info = {
    static int tps53679_probe(struct i2c_client *client,
    const struct i2c_device_id *id)
    {
    - return pmbus_do_probe(client, id, &tps53679_info);
    + struct pmbus_driver_info *info;
    +
    + info = devm_kmemdup(&client->dev, &tps53679_info, sizeof(*info),
    + GFP_KERNEL);
    + if (!info)
    + return -ENOMEM;
    +
    + return pmbus_do_probe(client, id, info);
    }

    static const struct i2c_device_id tps53679_id[] = {
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 10:50    [W:4.135 / U:0.336 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site