Messages in this thread | | | Date | Fri, 24 Jan 2020 10:16:29 -0800 | From | Bjorn Andersson <> | Subject | Re: [PATCH 7/7] arm64: dts: qcom: sm8250: Add sm8250 dts file |
| |
On Thu 16 Jan 15:39 PST 2020, Venkata Narendra Kumar Gutta wrote: > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi [..] > + clocks { > + xo_board: xo-board { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <38400000>; > + clock-output-names = "xo_board"; > + }; > + > + sleep_clk: sleep-clk { > + compatible = "fixed-clock"; > + clock-frequency = <32000>; > + #clock-cells = <1>;
This should be 0.
> + }; > + }; > + [..] > + smem: qcom,smem {
Please drop the "qcom," from the node name.
> + compatible = "qcom,smem"; > + memory-region = <&smem_mem>; > + hwlocks = <&tcsr_mutex 3>; > + }; > +
Regards, Bjorn
| |