Messages in this thread | | | Subject | Re: [PATCH v2 3/3] alarmtimer: Always export alarmtimer_get_rtcdev() and update docs | From | Stephen Boyd <> | Date | Thu, 23 Jan 2020 17:14:03 -0800 |
| |
Quoting Thomas Gleixner (2020-01-23 17:04:49) > Stephen Boyd <swboyd@chromium.org> writes: > > The export isn't there for the stubbed version of > > alarmtimer_get_rtcdev(), so move the export outside of the ifdef. And > > rtcdev isn't used outside of this ifdef so we don't need to redefine it > > as NULL. > > This does not make any sense. Why would we export a trivial stub which > just returns NULL? > > The right thing to do is to make that an inline function in the relevant > header file.
Ok. Will do.
> > > @@ -67,8 +67,6 @@ static DEFINE_SPINLOCK(rtcdev_lock); > > * alarmtimer_get_rtcdev - Return selected rtcdevice > > * > > * This function returns the rtc device to use for wakealarms. > > - * If one has not already been chosen, it checks to see if a > > - * functional rtc device is available. > > Unrelated comment change which is not explained in the changelog. Please > make that a separate patch as it has absolutely nothing to do with the > stub function issue. >
Fair enough. I only mentioned it with one word in the subject, 'docs'. Sorry about that.
| |