lkml.org 
[lkml]   [2020]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 116/222] i2c: tegra: Fix suspending in active runtime PM state
    Date
    From: Dmitry Osipenko <digetx@gmail.com>

    commit 9f42de8d4ec2304f10bbc51dc0484f3503d61196 upstream.

    I noticed that sometime I2C clock is kept enabled during suspend-resume.
    This happens because runtime PM defers dynamic suspension and thus it may
    happen that runtime PM is in active state when system enters into suspend.
    In particular I2C controller that is used for CPU's DVFS is often kept ON
    during suspend because CPU's voltage scaling happens quite often.

    Fixes: 8ebf15e9c869 ("i2c: tegra: Move suspend handling to NOIRQ phase")
    Cc: <stable@vger.kernel.org> # v5.4+
    Tested-by: Thierry Reding <treding@nvidia.com>
    Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
    Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/i2c/busses/i2c-tegra.c | 9 +++++++++
    1 file changed, 9 insertions(+)

    --- a/drivers/i2c/busses/i2c-tegra.c
    +++ b/drivers/i2c/busses/i2c-tegra.c
    @@ -1710,9 +1710,14 @@ static int tegra_i2c_remove(struct platf
    static int __maybe_unused tegra_i2c_suspend(struct device *dev)
    {
    struct tegra_i2c_dev *i2c_dev = dev_get_drvdata(dev);
    + int err;

    i2c_mark_adapter_suspended(&i2c_dev->adapter);

    + err = pm_runtime_force_suspend(dev);
    + if (err < 0)
    + return err;
    +
    return 0;
    }

    @@ -1733,6 +1738,10 @@ static int __maybe_unused tegra_i2c_resu
    if (err)
    return err;

    + err = pm_runtime_force_resume(dev);
    + if (err < 0)
    + return err;
    +
    i2c_mark_adapter_resumed(&i2c_dev->adapter);

    return 0;

    \
     
     \ /
      Last update: 2020-01-22 14:30    [W:5.653 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site