lkml.org 
[lkml]   [2020]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 192/222] Revert "arm64: dts: juno: add dma-ranges property"
    Date
    From: Sudeep Holla <sudeep.holla@arm.com>

    commit 54fb3fe0f211d4729a2551cf9497bd612189af9d upstream.

    This reverts commit 193d00a2b35ee3353813b4006a18131122087205.

    Commit 951d48855d86 ("of: Make of_dma_get_range() work on bus nodes")
    reworked the logic such that of_dma_get_range() works correctly
    starting from a bus node containing "dma-ranges".

    Since on Juno we don't have a SoC level bus node and "dma-ranges" is
    present only in the root node, we get the following error:

    OF: translation of DMA address(0) to CPU address failed node(/sram@2e000000)
    OF: translation of DMA address(0) to CPU address failed node(/uart@7ff80000)
    ...
    OF: translation of DMA address(0) to CPU address failed node(/mhu@2b1f0000)
    OF: translation of DMA address(0) to CPU address failed node(/iommu@2b600000)
    OF: translation of DMA address(0) to CPU address failed node(/iommu@2b600000)
    OF: translation of DMA address(0) to CPU address failed node(/iommu@2b600000)

    So let's fix it by dropping the "dma-ranges" property for now. This
    should be fine since it doesn't represent any kind of device-visible
    restriction; it was only there for completeness, and we've since given
    in to the assumption that missing "dma-ranges" implies a 1:1 mapping
    anyway.

    We can add it later with a proper SoC bus node and moving all the
    devices that belong there along with the "dma-ranges" if required.

    Fixes: 193d00a2b35e ("arm64: dts: juno: add dma-ranges property")
    Cc: Rob Herring <robh+dt@kernel.org>
    Cc: Liviu Dudau <liviu.dudau@arm.com>
    Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
    Acked-by: Robin Murphy <robin.murphy@arm.com>
    Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/arm64/boot/dts/arm/juno-base.dtsi | 1 -
    1 file changed, 1 deletion(-)

    --- a/arch/arm64/boot/dts/arm/juno-base.dtsi
    +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
    @@ -6,7 +6,6 @@
    /*
    * Devices shared by all Juno boards
    */
    - dma-ranges = <0 0 0 0 0x100 0>;

    memtimer: timer@2a810000 {
    compatible = "arm,armv7-timer-mem";

    \
     
     \ /
      Last update: 2020-01-22 14:29    [W:4.490 / U:0.340 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site