lkml.org 
[lkml]   [2020]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] riscv: change CSR M/S defines to use "X" for prefix
On Tue, 07 Jan 2020 03:15:56 PST (-0800), Paul Walmsley wrote:
> On Fri, 3 Jan 2020, Olof Johansson wrote:
>
>> Sure, this does the job. I'd personally prefer consistent prefixes but
>> that's just bikeshed color preferences -- this is fine.
>
> Thanks for the ack. For what it's worth, we're in agreement that we
> should prophylactically place RV_ prefixes on the rest of the CSR_ macro
> names. I just would prefer that it's done outside the late -rc series,
> since it's not technically a fix.

Olof: are you going to send a v2 of this patch that converts everything else
over or do you want me to? I think we all agree it's the right way to go, Paul
was just trying to limit the scope of the change late in the RC cycle. I'd
like to get this on for-next sooner rather than later as it'll probably
conflict with everything.

>> (Builds are still failing for some configs, but will be fixed if/when
>> you pick up https://lore.kernel.org/linux-riscv/20191217040631.91886-1-olof@lixom.net/)
>
> That one is on my radar - just haven't had a chance to review/test it
> yet. Thanks for sending that one too!
>
>
> - Paul

\
 
 \ /
  Last update: 2020-01-23 01:23    [W:0.059 / U:7.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site