lkml.org 
[lkml]   [2020]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH net-next] devlink: Add health recover notifications on devlink flows
Date
On Mon, 2020-01-20 at 10:50 +0100, David Miller wrote:
> From: Moshe Shemesh <moshe@mellanox.com>
> Date: Sun, 19 Jan 2020 17:04:28 +0200
>
> > Devlink health recover notifications were added only on driver
> direct
> > updates of health_state through
> devlink_health_reporter_state_update().
> > Add notifications on updates of health_state by devlink flows of
> report
> > and recover.
> >
> > Fixes: 97ff3bd37fac ("devlink: add devink notification when
> reporter update health state")
> > Signed-off-by: Moshe Shemesh <moshe@mellanox.com>
> > Acked-by: Jiri Pirko <jiri@mellanox.com>
>
> I really dislike forward declarations and almost all of the time they
> are
> unnecessary.
>

Hi Dave, a question just for educational purposes, i agree regarding
function forward declarations, bottom-up organizing should always be
followed.

But how about type forward declaration ? for hiding struct details in
specifc c file.. is it a bad practice ?

I use this trick a lot in mlx5, for detail hiding and module separation
..

> Could you please just rearrange the code as needed and resubmit?
>
> Thank you.
\
 
 \ /
  Last update: 2020-01-21 21:52    [W:0.082 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site