lkml.org 
[lkml]   [2020]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 01/38] platform/x86: intel_mid_powerbtn: Take a copy of ddata
    Date
    The driver gets driver_data from memory that is marked as const (which
    is probably put to read-only memory) and it then modifies it. This
    likely causes some sort of fault to happen.

    Fix this by taking a copy of the structure.

    Fixes: c94a8ff14de3 ("platform/x86: intel_mid_powerbtn: make mid_pb_ddata const")
    Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
    Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    ---
    drivers/platform/x86/intel_mid_powerbtn.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/platform/x86/intel_mid_powerbtn.c b/drivers/platform/x86/intel_mid_powerbtn.c
    index 292bace83f1e..6f436836fe50 100644
    --- a/drivers/platform/x86/intel_mid_powerbtn.c
    +++ b/drivers/platform/x86/intel_mid_powerbtn.c
    @@ -146,9 +146,10 @@ static int mid_pb_probe(struct platform_device *pdev)

    input_set_capability(input, EV_KEY, KEY_POWER);

    - ddata = (struct mid_pb_ddata *)id->driver_data;
    + ddata = devm_kmemdup(&pdev->dev, (void *)id->driver_data,
    + sizeof(*ddata), GFP_KERNEL);
    if (!ddata)
    - return -ENODATA;
    + return -ENOMEM;

    ddata->dev = &pdev->dev;
    ddata->irq = irq;
    --
    2.24.1
    \
     
     \ /
      Last update: 2020-01-21 17:05    [W:6.437 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site