Messages in this thread | | | Subject | Re: [PATCH 05/14] x86/mm: Introduce lookup_address_in_mm() | From | Paolo Bonzini <> | Date | Tue, 21 Jan 2020 15:26:28 +0100 |
| |
On 09/01/20 22:04, Thomas Gleixner wrote: > Sean Christopherson <sean.j.christopherson@intel.com> writes: > >> diff --git a/arch/x86/include/asm/pgtable_types.h b/arch/x86/include/asm/pgtable_types.h >> index b5e49e6bac63..400ac8da75e8 100644 >> --- a/arch/x86/include/asm/pgtable_types.h >> +++ b/arch/x86/include/asm/pgtable_types.h >> @@ -561,6 +561,10 @@ static inline void update_page_count(int level, unsigned long pages) { } >> extern pte_t *lookup_address(unsigned long address, unsigned int *level); >> extern pte_t *lookup_address_in_pgd(pgd_t *pgd, unsigned long address, >> unsigned int *level); >> + >> +struct mm_struct; >> +pte_t *lookup_address_in_mm(struct mm_struct *mm, unsigned long address, >> + unsigned int *level); > > Please keep the file consistent and use extern even if not required. > > Other than that: > > Reviewed-by: Thomas Gleixner <tglx@linutronix.de> >
Adjusted, thanks for the review.
Paolo
| |