lkml.org 
[lkml]   [2020]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drivers: optee: Fix compilation issue.
From
Date
Hi Greg,

I sent the fix below few days ago to the optee maintaners but I did not get any
answer. Could you please pick it up?

On 10/01/2020 12:28, Vincenzo Frascino wrote:
> The optee driver uses specific page table types to verify if a memory
> region is normal. These types are not defined in nommu systems. Trying
> to compile the driver in these systems results in a build error:
>
> linux/drivers/tee/optee/call.c: In function ‘is_normal_memory’:
> linux/drivers/tee/optee/call.c:533:26: error: ‘L_PTE_MT_MASK’ undeclared
> (first use in this function); did you mean ‘PREEMPT_MASK’?
> return (pgprot_val(p) & L_PTE_MT_MASK) == L_PTE_MT_WRITEALLOC;
> ^~~~~~~~~~~~~
> PREEMPT_MASK
> linux/drivers/tee/optee/call.c:533:26: note: each undeclared identifier is
> reported only once for each function it appears in
> linux/drivers/tee/optee/call.c:533:44: error: ‘L_PTE_MT_WRITEALLOC’ undeclared
> (first use in this function)
> return (pgprot_val(p) & L_PTE_MT_MASK) == L_PTE_MT_WRITEALLOC;
> ^~~~~~~~~~~~~~~~~~~
>
> Make the optee driver depend on MMU to fix the compilation issue.
>
> Cc: Jens Wiklander <jens.wiklander@linaro.org>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> ---
> drivers/tee/optee/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tee/optee/Kconfig b/drivers/tee/optee/Kconfig
> index d1ad512e1708..3ca71e3812ed 100644
> --- a/drivers/tee/optee/Kconfig
> +++ b/drivers/tee/optee/Kconfig
> @@ -3,6 +3,7 @@
> config OPTEE
> tristate "OP-TEE"
> depends on HAVE_ARM_SMCCC
> + depends on MMU
> help
> This implements the OP-TEE Trusted Execution Environment (TEE)
> driver.
>

--
Regards,
Vincenzo
[unhandled content-type:application/pgp-keys]
\
 
 \ /
  Last update: 2020-01-21 15:23    [W:0.763 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site