lkml.org 
[lkml]   [2020]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH net 2/9] r8152: reset flow control patch when linking on for RTL8153B
Date
Joe Perches [mailto:joe@perches.com]
> Sent: Tuesday, January 21, 2020 9:01 PM
> To: David Miller; Hayes Wang
[...]
> > > static int rtl8153_enable(struct r8152 *tp)
> > > {
> > > + u32 ocp_data;
> > > if (test_bit(RTL8152_UNPLUG, &tp->flags))
> > > return -ENODEV;
> > >
> >
> > Please put an empty line after the local variable declarations.
>
> Local scoping is generally better.
>
> Perhaps declare ocp_data inside the if branch
> where it's used.

OK. I would move it.

Best Regards,
Hayes

\
 
 \ /
  Last update: 2020-01-21 14:20    [W:0.181 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site