lkml.org 
[lkml]   [2020]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
SubjectRe: [PATCH v4 1/2] wan/hdlc_x25: make lapb params configurable
From
From: David Miller <davem@davemloft.net>
Date: Tue, 21 Jan 2020 11:41:52 +0100 (CET)

> From: Martin Schiller <ms@dev.tdt.de>
> Date: Tue, 21 Jan 2020 07:00:33 +0100
>
>> This enables you to configure mode (DTE/DCE), Modulo, Window, T1, T2, N2 via
>> sethdlc (which needs to be patched as well).
>>
>> Signed-off-by: Martin Schiller <ms@dev.tdt.de>
>
> Applied to net-next.

I seriously wonder how much you tested this code, because the compiler warned
me about:

diff --git a/drivers/net/wan/hdlc_x25.c b/drivers/net/wan/hdlc_x25.c
index 63c9aeed9a34..c84536b03aa8 100644
--- a/drivers/net/wan/hdlc_x25.c
+++ b/drivers/net/wan/hdlc_x25.c
@@ -253,7 +253,7 @@ static int x25_ioctl(struct net_device *dev, struct ifreq *ifr)
return -EBUSY;

/* backward compatibility */
- if (ifr->ifr_settings.size = 0) {
+ if (ifr->ifr_settings.size == 0) {
new_settings.dce = 0;
new_settings.modulo = 8;
new_settings.window = 7;
I'll commit that fix, but this is truly careless especially since the compiler
warns about it.

\
 
 \ /
  Last update: 2020-01-21 12:02    [W:0.085 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site