Messages in this thread | | | Subject | Re: [PATCH] powerpc/sysdev: fix compile errors | From | Andrew Donnellan <> | Date | Tue, 21 Jan 2020 17:13:07 +1100 |
| |
On 21/1/20 4:31 pm, wangwenhu wrote: > From: wangwenhu <wenhu.wang@vivo.com> > > Include arch/powerpc/include/asm/io.h into fsl_85xx_cache_sram.c to > fix the implicit declaration compile errors when building Cache-Sram. > > arch/powerpc/sysdev/fsl_85xx_cache_sram.c: In function ‘instantiate_cache_sram’: > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:26: error: implicit declaration of function ‘ioremap_coherent’; did you mean ‘bitmap_complement’? [-Werror=implicit-function-declaration] > cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys, > ^~~~~~~~~~~~~~~~ > bitmap_complement > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:24: error: assignment makes pointer from integer without a cast [-Werror=int-conversion] > cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys, > ^ > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:123:2: error: implicit declaration of function ‘iounmap’; did you mean ‘roundup’? [-Werror=implicit-function-declaration] > iounmap(cache_sram->base_virt); > ^~~~~~~ > roundup > cc1: all warnings being treated as errors > > Signed-off-by: wangwenhu <wenhu.wang@vivo.com>
How long has this code been broken for?
> --- > arch/powerpc/sysdev/fsl_85xx_cache_sram.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c > index f6c665dac725..29b6868eff7d 100644 > --- a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c > +++ b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c > @@ -17,6 +17,7 @@ > #include <linux/of_platform.h> > #include <asm/pgtable.h> > #include <asm/fsl_85xx_cache_sram.h> > +#include <asm/io.h> > > #include "fsl_85xx_cache_ctlr.h" >
-- Andrew Donnellan OzLabs, ADL Canberra ajd@linux.ibm.com IBM Australia Limited
| |