lkml.org 
[lkml]   [2020]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] trace/kprobe: remove MAX_KPROBE_CMDLINE_SIZE
On Tue, 21 Jan 2020 18:34:38 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> Masami,
>
> With your new bootconfig work, will you be utilizing
> MAX_KPROBE_CMDLINE_SIZE, or should it be removed?

Good catch! Yes, please remove it.
I think I have forgot to remove it when I switched
to COMMAND_LINE_SIZE while writing the code.

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thank you!

>
> -- Steve
>
>
> On Tue, 21 Jan 2020 13:54:35 +0800
> Alex Shi <alex.shi@linux.alibaba.com> wrote:
>
> > This limitation are never lunched from introduce commit 970988e19eb0
> > ("tracing/kprobe: Add kprobe_event= boot parameter")
> >
> > Could we remove it if no intention to implement it?
> >
> > Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
> > Cc: Steven Rostedt <rostedt@goodmis.org>
> > Cc: Ingo Molnar <mingo@redhat.com>
> > Cc: linux-kernel@vger.kernel.org
> > ---
> > kernel/trace/trace_kprobe.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
> > index 7f890262c8a3..eafa90d0f760 100644
> > --- a/kernel/trace/trace_kprobe.c
> > +++ b/kernel/trace/trace_kprobe.c
> > @@ -22,7 +22,6 @@
> >
> > #define KPROBE_EVENT_SYSTEM "kprobes"
> > #define KRETPROBE_MAXACTIVE_MAX 4096
> > -#define MAX_KPROBE_CMDLINE_SIZE 1024
> >
> > /* Kprobe early definition from command line */
> > static char kprobe_boot_events_buf[COMMAND_LINE_SIZE] __initdata;
>


--
Masami Hiramatsu <mhiramat@kernel.org>

\
 
 \ /
  Last update: 2020-01-22 05:20    [W:0.050 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site