Messages in this thread | | | Date | Tue, 21 Jan 2020 09:49:51 +0800 | From | Wei Yang <> | Subject | Re: [Patch v2 3/4] mm/page_alloc.c: pass all bad reasons to bad_page() |
| |
On Mon, Jan 20, 2020 at 01:19:10PM +0100, David Hildenbrand wrote: >On 20.01.20 11:22, Michal Hocko wrote: >> On Mon 20-01-20 11:04:14, Wei Yang wrote: >>> Now we can pass all bad reasons to __dump_page(). >> >> And we do we want to do that? The dump of the page will tell us the >> whole story so a single and the most important reason sounds like a >> better implementation. The code is also more subtle because each caller >> of the function has to be aware of how many reasons there might be. >> Not to mention that you need a room for 5 pointers on the stack and this >> and page allocator might be called from deeper call chains. >> > >+1, I don't think we want/need this >
Well, I am fine with both.
Sounds we have 2 vs 2 voting :-)
> >-- >Thanks, > >David / dhildenb
-- Wei Yang Help you, Help me
| |