Messages in this thread | | | Subject | Re: [alsa-devel] [PATCH 2/9] ASoC: tegra: add support for CIF programming | From | Dmitry Osipenko <> | Date | Mon, 20 Jan 2020 18:58:11 +0300 |
| |
Hello Sameer,
20.01.2020 17:23, Sameer Pujar пишет:
[snip]
> Tegra30 and Tegra124 have an identical CIF programming helper function.
[snip]
> -#define TEGRA124_AUDIOCIF_CTRL_FIFO_THRESHOLD_SHIFT 24 > -#define TEGRA124_AUDIOCIF_CTRL_FIFO_THRESHOLD_MASK_US 0x3f > -#define TEGRA124_AUDIOCIF_CTRL_FIFO_THRESHOLD_MASK (TEGRA124_AUDIOCIF_CTRL_FIFO_THRESHOLD_MASK_US << TEGRA124_AUDIOCIF_CTRL_FIFO_THRESHOLD_SHIFT) > - > -/* Channel count minus 1 */ > -#define TEGRA30_AUDIOCIF_CTRL_AUDIO_CHANNELS_SHIFT 24 > -#define TEGRA30_AUDIOCIF_CTRL_AUDIO_CHANNELS_MASK_US 7 > -#define TEGRA30_AUDIOCIF_CTRL_AUDIO_CHANNELS_MASK (TEGRA30_AUDIOCIF_CTRL_AUDIO_CHANNELS_MASK_US << TEGRA30_AUDIOCIF_CTRL_AUDIO_CHANNELS_SHIFT)
The AUDIOCIF_CTRL bitfields are not the same on T30 and T124, why are you claiming that programming is identical? Have you actually tried to test these patches on T30?
| |