Messages in this thread | | | Subject | Re: [PATCH -mm] mm/page_isolation: fix potential warning from user | From | David Hildenbrand <> | Date | Mon, 20 Jan 2020 10:42:52 +0100 |
| |
>>> + } else { >>> + if (isol_flags & MEMORY_OFFLINE) >>> + WARN_ON_ONCE(zone_idx(zone) == ZONE_MOVABLE);> + >>> + if ((isol_flags & REPORT_FAILURE) && !IS_ERR(unmovable)) >>> + /* >>> + * printk() with zone->lock held will likely trigger a >>> + * lockdep splat, so defer it here. >>> + */ >>> + dump_page(unmovable, "unmovable page"); >>> + } >>> + >>> + return !!unmovable; >>> } >>> >>> static void unset_migratetype_isolate(struct page *page, unsigned migratetype) >> >> set_migratetype_isolate() gets called from CMA as well as HugeTLB >> allocation paths, so its not only during offline. Hence the commit >> message should be changed to reflect this. > > We should just report for all those cases I believe. >
+1
-- Thanks,
David / dhildenb
| |