lkml.org 
[lkml]   [2020]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -mm] mm/page_isolation: fix potential warning from user
From
Date
>>> +	} else {
>>> + if (isol_flags & MEMORY_OFFLINE)
>>> + WARN_ON_ONCE(zone_idx(zone) == ZONE_MOVABLE);> +
>>> + if ((isol_flags & REPORT_FAILURE) && !IS_ERR(unmovable))
>>> + /*
>>> + * printk() with zone->lock held will likely trigger a
>>> + * lockdep splat, so defer it here.
>>> + */
>>> + dump_page(unmovable, "unmovable page");
>>> + }
>>> +
>>> + return !!unmovable;
>>> }
>>>
>>> static void unset_migratetype_isolate(struct page *page, unsigned migratetype)
>>
>> set_migratetype_isolate() gets called from CMA as well as HugeTLB
>> allocation paths, so its not only during offline. Hence the commit
>> message should be changed to reflect this.
>
> We should just report for all those cases I believe.
>

+1

--
Thanks,

David / dhildenb

\
 
 \ /
  Last update: 2020-01-20 10:43    [W:0.045 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site