lkml.org 
[lkml]   [2020]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 117/137] scsi: pm80xx: Fix for SATA device discovery
    Date
    From: peter chang <dpf@google.com>

    [ Upstream commit ce21c63ee995b7a8b7b81245f2cee521f8c3c220 ]

    Driver was missing complete() call in mpi_sata_completion which result in
    SATA abort error handling timing out. That causes the device to be left in
    the in_recovery state so subsequent commands sent to the device fail and
    the OS removes access to it.

    Link: https://lore.kernel.org/r/20191114100910.6153-2-deepak.ukey@microchip.com
    Acked-by: Jack Wang <jinpu.wang@cloud.ionos.com>
    Signed-off-by: peter chang <dpf@google.com>
    Signed-off-by: Deepak Ukey <deepak.ukey@microchip.com>
    Signed-off-by: Viswas G <Viswas.G@microchip.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/pm8001/pm80xx_hwi.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c
    index 9edd61c063a1..df5f0bc29587 100644
    --- a/drivers/scsi/pm8001/pm80xx_hwi.c
    +++ b/drivers/scsi/pm8001/pm80xx_hwi.c
    @@ -2368,6 +2368,8 @@ mpi_sata_completion(struct pm8001_hba_info *pm8001_ha, void *piomb)
    pm8001_printk("task 0x%p done with io_status 0x%x"
    " resp 0x%x stat 0x%x but aborted by upper layer!\n",
    t, status, ts->resp, ts->stat));
    + if (t->slow_task)
    + complete(&t->slow_task->completion);
    pm8001_ccb_task_free(pm8001_ha, t, ccb, tag);
    } else {
    spin_unlock_irqrestore(&t->task_state_lock, flags);
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-02 23:39    [W:5.191 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site