lkml.org 
[lkml]   [2020]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 4/9] drivers: thermal: tsens: Release device in success path
    Date
    We don't currently call put_device in case of successfully initialising
    the device.

    Allow control to fall through so we can use same code for success and
    error paths to put_device.

    Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
    ---
    drivers/thermal/qcom/tsens-common.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c
    index 1cbc5a6e5b4f..e84e94a6f1a7 100644
    --- a/drivers/thermal/qcom/tsens-common.c
    +++ b/drivers/thermal/qcom/tsens-common.c
    @@ -687,8 +687,6 @@ int __init init_common(struct tsens_priv *priv)
    tsens_enable_irq(priv);
    tsens_debug_init(op);

    - return 0;
    -
    err_put_device:
    put_device(&op->dev);
    return ret;
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-01-02 15:56    [W:2.281 / U:0.556 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site