Messages in this thread | | | From | Felipe Balbi <> | Subject | Re: [PATCHv1 2/2] usb: gadget: add udc driver for max3420 | Date | Thu, 02 Jan 2020 13:31:22 +0200 |
| |
Hi,
Jassi Brar <jassisinghbrar@gmail.com> writes: >> > +static void __max3420_start(struct max3420_udc *udc) >> > +{ >> > + u8 val; >> > + >> > + /* Need this delay if bus-powered */ >> > + msleep_interruptible(250); >> >> should you check if you're bus powered? >> > for some reason, even for self-powered, it helped reliability.
Perhaps update the comment, in that case? It would be better if we had a proper explanation for this sleep here.
>> > +static int max3420_thread(void *dev_id) >> >> Why do you need this thread? Sure you can't live without it? >> > All the slow spi-bus transfers are handled at one place here without > blocking any api call. IMO it is cleaner and easier to manage.
Fair enough, I won't complain. But it looks odd :-p
-- balbi [unhandled content-type:application/pgp-signature]
| |